Handle empty ProForma formulas#98
Merged
Merged
Conversation
Member
|
Thanks for the fix. I think I inadvertently broke this recently when cleaning up this region of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an existing mzcore ProForma molecular formula parser panic for empty input.
Previously,
MolecularFormula::pro_forma::<_, true>("")could attempt an inclusive slice on an empty string and panic, even though empty formulas are documented as valid whenALLOW_EMPTYis enabled.Changes:
Detect empty input before slicing the requested formula range.
Preserve existing behavior:
Ok(default)whenALLOW_EMPTY = trueALLOW_EMPTY = falseAdd regression coverage for both accepted and rejected empty input.
Validated xith:
Both pass.